Add qualifying references to identifier references #5744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple pieces in the codebase that need information about the qualifying reference/declaration of a reference, e.g. to determine whether the reference is a member access on the return value of a specific member. Currently, checking this is achieved by navigating the parse tree each time, also taking into account with blocks. This PR moves the qualifier resolution to the
BoundExpressionVisitor
, which already has all the information present to easily determine the qualifying reference.The following qualifier structure has been implemented:
This PR is still WIP; it needs a lot more tests. Moreover, the places currently doing the work manually should be ported to use the qualifying reference, if possible.