Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable #14

Merged
merged 7 commits into from
Jul 6, 2020
Merged

Repeatable #14

merged 7 commits into from
Jul 6, 2020

Conversation

Mte90
Copy link
Contributor

@Mte90 Mte90 commented Mar 27, 2019

Right now the field frontend works but is not saving the value if it is in a metabox that is repeatable.
I am trying to understand where is the issue.

@Mte90
Copy link
Contributor Author

Mte90 commented Mar 27, 2019

Right now the field doesn't save the value on repeatable fields.
I am trying to understand what's happening but any help can be precious.

@Mte90
Copy link
Contributor Author

Mte90 commented Mar 27, 2019

I got it....
This field use the multiple parameter that is reserved to CMB2 so this was the reason of a lot of issues inside the field itself.
I changed to another one but is not yet finished because not save the values.

@Mte90
Copy link
Contributor Author

Mte90 commented Mar 27, 2019

I could not relax until I fix this after working all the afternoon.
Seems there was also other issues between id not standard and also name not standard.
I finished and tested and ready to be merged.

@Mte90
Copy link
Contributor Author

Mte90 commented Oct 1, 2019

just a ping

@Mte90
Copy link
Contributor Author

Mte90 commented Jun 30, 2020

ping @rubengc

@rubengc
Copy link
Owner

rubengc commented Jul 6, 2020

Hi @Mte90

Sorry for the delayed response but I have years without using this field since I switched to Select2

I'm planning to release the CMB2 Select2 field at some moment when I get less busy from my actual work with my projetcs GamiPress and AutomatorWP

Anyway, i will merge this pull request to let you get them added to this repo

Thank you so much for this contribution!

@rubengc rubengc merged commit d6ce604 into rubengc:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants