Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor default abs sender #272

Merged

Conversation

fedochet
Copy link
Contributor

I was studying your library and spotted some code duplication in DefaultAbsSender, so I decided to refactor it
I did not change any behavior - only rearranged some lines in order to make refactorings clearer

@codecov-io
Copy link

Codecov Report

Merging #272 into dev will decrease coverage by 0.7%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##               dev    #272      +/-   ##
==========================================
- Coverage     7.52%   6.82%   -0.71%     
+ Complexity     167     161       -6     
==========================================
  Files          145     145              
  Lines         4743    4659      -84     
  Branches       416     405      -11     
==========================================
- Hits           357     318      -39     
+ Misses        4344    4302      -42     
+ Partials        42      39       -3
Impacted Files Coverage Δ Complexity Δ
...g/telegram/telegrambots/bots/DefaultAbsSender.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...egrambots/updatesreceivers/ExponentialBackOff.java 32.81% <0%> (-18.75%) 4% <0%> (-4%)
...legrambots/updatesreceivers/DefaultBotSession.java 38.46% <0%> (-17.49%) 8% <0%> (ø)
.../telegram/telegrambots/bots/DefaultBotOptions.java 27.27% <0%> (-9.1%) 3% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6e9e7...4da6b35. Read the comment docs.

@fedochet
Copy link
Contributor Author

I am not sure why CodeCov fails - considering I didn't change mentioned files 😄

@rubenlagus rubenlagus merged commit cbcfab5 into rubenlagus:dev Jul 20, 2017
@rubenlagus rubenlagus self-assigned this Jul 20, 2017
@rubenlagus rubenlagus added this to the v3.2 milestone Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants