Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: remove cross fetch #76

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Jun 11, 2024

Removes the cross fetch function in favour of using the global fetch function. Needed in order to ensure that the tests in comunica/comunica#1372 passes offline.

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9473397763

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9384920891: 0.0%
Covered Lines: 551
Relevant Lines: 551

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jeswr jeswr requested a review from rubensworks June 13, 2024 12:57
@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9500056476

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9384920891: 0.0%
Covered Lines: 551
Relevant Lines: 551

💛 - Coveralls

@rubensworks rubensworks merged commit 8d26fba into rubensworks:master Jun 13, 2024
10 checks passed
@rubensworks
Copy link
Owner

Thanks! Released as 3.0.0.

@jeswr jeswr deleted the breaking/remove-cross-fetch branch June 13, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants