Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test cleanup #121

Closed
wants to merge 2 commits into from
Closed

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Nov 21, 2023

Makes use .resolve in jest.

I was actually trying to repro an error that I am seeing in another library where .resolve isn't behaving well with the readable-stream library but seems to work fine here 😕

@jeswr jeswr changed the title chore/test cleanup chore: test cleanup Nov 21, 2023
@rubensworks
Copy link
Owner

So the change is not really needed then? 😅
Maybe we can leave things as-is then, don't fix what ain't broken?

Also, the conversion of async to sync tests may not be that convenient, in case we'd need to await multiple things in tests in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants