Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use process shim #43

Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix: use process shim #43

merged 2 commits into from
Mar 29, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Mar 28, 2023 •
edited
Loading

Was struggling to test locally because yarn test was failing even before making any changes (tried on node 14 and 16). Lets see how the CI behaves...

@rubensworks
Copy link
Owner

See comunica/comunica#1186 (comment)

@jeswr
Copy link
Contributor Author

jeswr commented Mar 28, 2023

Fixed now @rubensworks

@rubensworks rubensworks merged commit 2accbad into rubensworks:master Mar 29, 2023
@rubensworks
Copy link
Owner

Thanks! Will wait for a new release until we merge the comunica PR.

@jeswr jeswr deleted the fix/use-process-shim branch March 29, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeswr @rubensworks