Merge pull request #11 from rubicon-project/prebid-1.0-prebidServer-B…

…ID_REQUEST-event s2s requests now firing BID_REQUESTED event
rubicon-project · Nov 22, 2017 · 35dcf5c · 35dcf5c
2 parents aba436e + a8c6cbf
commit 35dcf5c
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 0 deletions.
diff --git a/src/adaptermanager.js b/src/adaptermanager.js
@@ -243,6 +243,11 @@ exports.callBids = (adUnits, bidRequests, addBidResponse, doneCb) => {
           return allBidders.includes(adapter);
         }).join(',')}`);
 
+        // fire BID_REQUESTED event for each s2s bidRequest
+        serverBidRequests.forEach(bidRequest => {
+          events.emit(CONSTANTS.EVENTS.BID_REQUESTED, bidRequest);
+        });
+
         // make bid requests
         s2sAdapter.callBids(
           s2sBidRequest,

diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js
@@ -7,6 +7,7 @@ import { config } from 'src/config';
 import { registerBidder } from 'src/adapters/bidderFactory';
 import { setSizeConfig } from 'src/sizeMapping';
 var s2sTesting = require('../../../../modules/s2sTesting');
+var events = require('../../../../src/events');
 
 const CONFIG = {
   enabled: true,
@@ -90,6 +91,22 @@ describe('adapterManager tests', () => {
 
       sinon.assert.called(utils.logError);
     });
+
+    it('should emit BID_REQUESTED event', () => {
+      // function to count BID_REQUESTED events
+      let cnt = 0;
+      let count = () => cnt++;
+      events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      AdapterManager.bidderRegistry['appnexus'] = appnexusAdapterMock;
+      let adUnits = getAdUnits();
+      let bidRequests = AdapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
+      AdapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
+      expect(cnt).to.equal(1);
+      sinon.assert.calledOnce(appnexusAdapterMock.callBids);
+      appnexusAdapterMock.callBids.reset();
+      delete AdapterManager.bidderRegistry['appnexus'];
+      events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+    });
   });
 
   describe('S2S tests', () => {
@@ -253,6 +270,40 @@ describe('adapterManager tests', () => {
       expect(requestObj.ad_units.length).to.equal(2);
       sinon.assert.calledOnce(prebidServerAdapterMock.callBids);
     });
+
+    describe('BID_REQUESTED event', () => {
+      // function to count BID_REQUESTED events
+      let cnt, count = () => cnt++;
+
+      beforeEach(() => {
+        cnt = 0;
+        events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      });
+
+      afterEach(() => {
+        events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      });
+
+      it('should fire for s2s requests', () => {
+        let adUnits = getAdUnits();
+        let bidRequests = AdapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
+        AdapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
+        expect(cnt).to.equal(1);
+        sinon.assert.calledOnce(prebidServerAdapterMock.callBids);
+      });
+
+      it('should fire for simultaneous s2s and client requests', () => {
+        AdapterManager.bidderRegistry['adequant'] = adequantAdapterMock;
+        let adUnits = getAdUnits();
+        let bidRequests = AdapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
+        AdapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
+        expect(cnt).to.equal(2);
+        sinon.assert.calledOnce(prebidServerAdapterMock.callBids);
+        sinon.assert.calledOnce(adequantAdapterMock.callBids);
+        adequantAdapterMock.callBids.reset();
+        delete AdapterManager.bidderRegistry['adequant'];
+      });
+    });
   }); // end s2s tests
 
   describe('s2sTesting', () => {