airgridRtdProvider: use provided tag insertion method `loadExternalSc…

…ript` (prebid#9901)

* chore: update `getAudiencesAsBidderOrtb2` implementation and test

* chore: use provided tag insertion method

* fix: add `airgrid` to `_approvedLoadExternalJSList`

* fix: use 'sdk' path if no publisherId is provided

* fix: use accountId as path param for script url

* fix: assign edktInitializor props before `loadExternalScript` call

* fix: set `edktInitializor.invoked` before calling `loadExternalScript`

* fix: restore method for setting `user.ext.data`
feat: extend module data setting using `user.keywords` for appnexus

* fix: rollback changes to data setting method

modules/airgridRtdProvider.js

@@ -12,8 +12,9 @@ import {
   deepAccess,
 } from '../src/utils.js';
 import { getGlobal } from '../src/prebidGlobal.js';
-import {getStorageManager} from '../src/storageManager.js';
-import {MODULE_TYPE_RTD} from '../src/activities/modules.js';
+import { getStorageManager } from '../src/storageManager.js';
+import { loadExternalScript } from '../src/adloader.js';
+import { MODULE_TYPE_RTD } from '../src/activities/modules.js';
 
 const MODULE_NAME = 'realTimeData';
 const SUBMODULE_NAME = 'airgrid';
@@ -25,6 +26,11 @@ export const storage = getStorageManager({
   moduleName: SUBMODULE_NAME,
 });
 
+function getModuleUrl(accountId) {
+  const path = accountId ?? 'sdk';
+  return `https://cdn.edkt.io/${path}/edgekit.min.js`;
+}
+
 /**
  * Attach script tag to DOM
  * @param {Object} rtdConfig
@@ -33,19 +39,12 @@ export const storage = getStorageManager({
 export function attachScriptTagToDOM(rtdConfig) {
   var edktInitializor = (window.edktInitializor = window.edktInitializor || {});
   if (!edktInitializor.invoked) {
-    edktInitializor.invoked = true;
     edktInitializor.accountId = rtdConfig.params.accountId;
     edktInitializor.publisherId = rtdConfig.params.publisherId;
     edktInitializor.apiKey = rtdConfig.params.apiKey;
-    edktInitializor.load = function (e) {
-      var p = e || 'sdk';
-      var n = document.createElement('script');
-      n.type = 'module';
-      n.async = true;
-      n.src = 'https://cdn.edkt.io/' + p + '/edgekit.min.js';
-      document.getElementsByTagName('head')[0].appendChild(n);
-    };
-    edktInitializor.load(edktInitializor.accountId);
+    edktInitializor.invoked = true;
+    const moduleSrc = getModuleUrl(rtdConfig.params.accountId);
+    loadExternalScript(moduleSrc, SUBMODULE_NAME);
   }
 }
 

src/adloader.js

@@ -23,6 +23,7 @@ const _approvedLoadExternalJSList = [
   'aaxBlockmeter',
   'confiant',
   'arcspan',
+  'airgrid',
   'clean.io'
 ]
 

test/spec/modules/airgridRtdProvider_spec.js

@@ -2,6 +2,7 @@ import { config } from 'src/config.js';
 import { deepAccess } from 'src/utils.js';
 import { getAdUnits } from '../../fixtures/fixtures.js';
 import * as agRTD from 'modules/airgridRtdProvider.js';
+import { loadExternalScript } from '../../../src/adloader.js';
 
 const MATCHED_AUDIENCES = ['travel', 'sport'];
 const RTD_CONFIG = {
@@ -40,6 +41,7 @@ describe('airgrid RTD Submodule', function () {
       expect(agRTD.airgridSubmodule.init(RTD_CONFIG.dataProviders[0])).to.equal(
         true
       );
+      expect(loadExternalScript.called).to.be.true
     });
 
     it('should attach script to DOM with correct config', function () {