Use refinements to support Ruby <= 2.6 Range#minmax #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
minmax
branch
2 times, most recently
from
e244bc2 to
0bfc76f
Compare
Earlopain
added a commit
to Earlopain/rubocop-ast
that referenced
this pull request
Aug 3, 2024
It was added for a bug in Ruby <= 2.7 The minimum version now is 2.7 so it is not needed anymore. rubocop#151 ``` irb(main):001:0> RUBY_VERSION => "2.6.10" irb(main):002:0> Range.instance_method(:minmax).owner != ::Range => true irb(main):002> RUBY_VERSION => "2.7.8" irb(main):003> Range.instance_method(:minmax).owner != ::Range => false ```
koic
pushed a commit
that referenced
this pull request
Aug 3, 2024
It was added for a bug in Ruby <= 2.7 The minimum version now is 2.7 so it is not needed anymore. #151 ``` irb(main):001:0> RUBY_VERSION => "2.6.10" irb(main):002:0> Range.instance_method(:minmax).owner != ::Range => true irb(main):002> RUBY_VERSION => "2.7.8" irb(main):003> Range.instance_method(:minmax).owner != ::Range => false ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the code and cleaner detection.
See this discussion