reminds probably was meant to be resembles
#344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
reviewed
Dec 12, 2024
| @@ -3,7 +3,7 @@ | |||
| Node pattern is a DSL to help find specific nodes in the Abstract Syntax Tree | |||
| using a simple string. | |||
|
|
|||
| It reminds the simplicity of regular expressions but used to find specific | |||
| It resembles the simplicity of regular expressions but used to find specific | |||
There was a problem hiding this comment.
I guess it was supposed to be this?
Suggested change
| It resembles the simplicity of regular expressions but used to find specific | |
| It reminds of the simplicity of regular expressions but is used to find specific |
There was a problem hiding this comment.
It reminds of the is not clear English.
Adding the 2nd is does make sense though.
There was a problem hiding this comment.
updated the PR w/ the change
There was a problem hiding this comment.
You might say:
It reminds one of the simplicity.. or It may remind you of the simplicity... but that sounds too informal.
Kallin
commented
Dec 12, 2024
|
even better: |
|
Good catch. I changed it to "Node pattern is a DSL to help find specific nodes in the Abstract Syntax Tree |
That's nice, I went for that and put you as author @Kallin , thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there's a typo in the
node_patterndocs. This change fixes the sentence.