[Fix #1078] Fix false negative for Rails/LexicallyScopedActionFilter
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-pisanov
commented
Aug 31, 2023
Comment on lines
+129
to
+133
| unmatched_methods = array_values(methods_node) - defined_action_methods | ||
| return if unmatched_methods.empty? | ||
|
|
||
| message = message(methods, parent) | ||
| add_offense(node, message: message) unless methods.empty? | ||
| message = message(unmatched_methods, parent) | ||
| add_offense(node, message: message) |
There was a problem hiding this comment.
minor readability/performance improvement
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1078
This PR fixes the edge case where the class/module body does not define any methods at all.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.