Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert false positives in SkipsModelValidations #290

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

eugeneius
Copy link
Contributor

Adding insert to the forbidden methods list for SkipsModelValidations in #289 introduced false positives, particularly since String#insert and Array#insert are commonly used.

We can reduce the impact by matching on the arguments: Active Record's insert method takes one positional argument and two optional keyword arguments (:returning and :unique_by). Anything else can be ignored.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Adding `insert` to the forbidden methods list for SkipsModelValidations
in 27b0591 introduced false positives,
particularly since String#insert and Array#insert are commonly used.

We can reduce the impact by matching on the arguments: Active Record's
`insert` method takes one positional argument and two optional keyword
arguments (`:returning` and `:unique_by`). Anything else can be ignored.
@koic koic merged commit 7e8f9ff into rubocop:master Jul 9, 2020
@koic
Copy link
Member

koic commented Jul 9, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants