Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore InternalAffairs/CreateEmptyFile in #create_empty_file #828

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Oct 23, 2022

This is in response to the following change:

This repository refers to rubocop/rubocop on GitHub and does not stage Gemfile.lock in Git index, so if a cop that detects offenses to existing code is added on rubocop gem side, the CI on rubocop-rails gem side will start to fail from that point on.

gem 'rubocop', github: 'rubocop/rubocop'

I ran into this problem when I created the following Pull Request, so I decided to create this Pull Request too.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@r7kamura
Copy link
Contributor Author

I think it is preferable to deal with it this way for the time being to solve the current problem. However, in the future, it may be better to solve this problem by providing FileHelper from rubocop gem and remove the similar implementation from rubocop-rails side.

@koic koic merged commit 1acb097 into rubocop:master Oct 23, 2022
@koic
Copy link
Member

koic commented Oct 23, 2022

it may be better to solve this problem by providing FileHelper from rubocop gem and remove the similar implementation from rubocop-rails side.

Yep, I think so too.

@r7kamura r7kamura deleted the feature/create-empty-file branch October 23, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants