Merge pull request #1589 from ydah/ydah/fix-1588

Fix an incorrect autocorrect for `RSpec/VerifiedDoubleReference` when namespaced class
rubocop · Mar 6, 2023 · b4c2ae0 · b4c2ae0
2 parents d114b99 + aa125ef
commit b4c2ae0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@
 - Fix a false positive for `RSpec/PendingWithoutReason` when `skip` is passed a block inside example. ([@ydah], [@pirj])
 - Rename `RSpec/PendingBlockInsideExample` cop to `RSpec/SkipBlockInsideExample`. ([@pirj])
 - Deprecate `send_pattern`/`block_pattern`/`numblock_pattern` helpers in favour of using node pattern explicitly. ([@pirj], [@ydah])
+- Fix an incorrect autocorrect for `RSpec/VerifiedDoubleReference` when namespaced class. ([@ydah])
 
 ## 2.18.1 (2023-01-19)
 

diff --git a/lib/rubocop/cop/rspec/verified_double_reference.rb b/lib/rubocop/cop/rspec/verified_double_reference.rb
@@ -79,7 +79,7 @@ def on_send(node)
             expression = class_reference.source_range
 
             add_offense(expression, message: message) do |corrector|
-              violation = class_reference.children.last.to_s
+              violation = class_reference.source
               corrector.replace(expression, correct_style(violation))
 
               opposite_style_detected
@@ -102,7 +102,7 @@ def correct_style(violation)
           if style == :string
             "'#{violation}'"
           else
-            violation
+            violation.gsub(/^['"]|['"]$/, '')
           end
         end
       end

diff --git a/spec/rubocop/cop/rspec/verified_double_reference_spec.rb b/spec/rubocop/cop/rspec/verified_double_reference_spec.rb
@@ -27,10 +27,16 @@
           expect_offense(<<~RUBY, verified_double: verified_double)
             %{verified_double}('ClassName')
             _{verified_double} ^^^^^^^^^^^ Use a constant class reference for verified doubles.
+            %{verified_double}('Foo::Bar::Baz')
+            _{verified_double} ^^^^^^^^^^^^^^^ Use a constant class reference for verified doubles.
+            %{verified_double}('::Foo::Bar')
+            _{verified_double} ^^^^^^^^^^^^ Use a constant class reference for verified doubles.
           RUBY
 
           expect_correction(<<~RUBY)
             #{verified_double}(ClassName)
+            #{verified_double}(Foo::Bar::Baz)
+            #{verified_double}(::Foo::Bar)
           RUBY
         end
 
@@ -52,10 +58,16 @@
           expect_offense(<<~RUBY, verified_double: verified_double)
             %{verified_double}(ClassName)
             _{verified_double} ^^^^^^^^^ Use a string class reference for verified doubles.
+            %{verified_double}(Foo::Bar::Baz)
+            _{verified_double} ^^^^^^^^^^^^^ Use a string class reference for verified doubles.
+            %{verified_double}(::Foo::Bar)
+            _{verified_double} ^^^^^^^^^^ Use a string class reference for verified doubles.
           RUBY
 
           expect_correction(<<~RUBY)
             #{verified_double}('ClassName')
+            #{verified_double}('Foo::Bar::Baz')
+            #{verified_double}('::Foo::Bar')
           RUBY
         end