Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress deprecation warning for some cops #1936

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 10, 2024

Resolves rubocop/rubocop#13032 (comment).

Starting from RuboCop 1.65, using ConfigurableMax module API, which is deprecated, will trigger deprecation warnings.
This PR suppresses these warnings by using exclude_limit instead of the deprecated API.

Related PR: rubocop/rubocop#9471


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

Resolves rubocop/rubocop#13032 (comment).

Starting from RuboCop 1.65, using `ConfigurableMax` module API, which is deprecated,
will trigger deprecation warnings.
This PR suppresses these warnings by using `exclude_limit` instead of the deprecated API.

Related PR: rubocop/rubocop#9471
@koic koic requested a review from a team as a code owner July 10, 2024 18:37
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit 03034e7 into rubocop:master Jul 10, 2024
24 checks passed
@koic koic deleted the suppress_deprecation_warning_when_some_cops branch July 10, 2024 18:54
@ydah ydah mentioned this pull request Jul 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants