Migration helper module #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context 'when a change block is used outside of a Sequel migration' do | ||
| let(:source) do | ||
| <<~SOURCE | ||
| it { expect { subject }.to change { document_count(user_id) }.by(-1) } |
There was a problem hiding this comment.
Test case taken directly from the reported issue:
#44
cyberdelia
reviewed
Oct 24, 2024
cyberdelia
reviewed
Oct 24, 2024
| @@ -5,6 +5,8 @@ module Cop | |||
| module Sequel | |||
| # IrreversibleMigration looks for methods inside a `change` block that cannot be reversed. | |||
| class IrreversibleMigration < Base | |||
| include RuboCop::Cop::Sequel::Helpers::Migration | |||
There was a problem hiding this comment.
You may want to apply this to other migration related cops?
There was a problem hiding this comment.
Done! I've updated the PR description with these additional changes, and also created a spec helper module to wrap test code in a Sequel.migration block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue: #44
Bug was introduced in this PR: #43
Primary Change
IrreversibleMigrationwill now check if achangeblock is inside aSequel.migrationblock before checking for offensesNew patterns
lib
lib/rubocop/cop/sequel/helpers/module Migration(Can be included viainclude Helpers::Migration)Sequel.migrationblock before checking for offenses.spec
spec/rubocop/cop/sequel/helpersmodule Migration(Can be included viainclude Spec::Helpers::Migration)#inspect_source_within_migration#inspect_source. Will wrap thesourceargument within aSequel.migrationblock