Add support for AWS account onboarding without CloudFormation #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johan3141592
changed the title
leitzler
approved these changes
Sep 20, 2023
| if len(mappings) != 1 { | ||
| return uuid.Nil, errors.New("expected account mappings for a single account") | ||
| } | ||
| if msg := mappings[0].Message; msg == "" || !strings.Contains(msg, "RBK30300003") { |
There was a problem hiding this comment.
nit: Both the retry count (7) and the explicit error RBK30300003 could be commented to add some more context to the reader.
pkg/polaris/aws/aws.go
Outdated
| @@ -39,6 +40,10 @@ import ( | |||
| "github.com/rubrikinc/rubrik-polaris-sdk-for-go/pkg/polaris/log" | |||
| ) | |||
|
|
|||
| const ( | |||
| requestTimeout = 5 * time.Second | |||
There was a problem hiding this comment.
nit: maybe a comment about the background to choosing 5s
johan3141592
added a commit
that referenced
this pull request
Apr 11, 2024
* Add support for AWS account onboarding without CloudFormation (#128) * Support relative paths for the credentials file (#130) * Support reading credentials from current environment (#132) * Add support for bootstrapping Rubrik clusters (#127) * Improve error messages (#133) * Check if vars exist when reading credentials from env (#134) * Change ID type from uuid.UUID to string (#129) * Add support for AWS shared exocompute (#136) * Add support for AWS private container registry (#137) * Add support for AWS cloud archival location (#138) * Add aws exocompute update (#140) (#143) * Update aws exocompute config fields (#144) * Do not populate non-existing aws exo config subnets (#145) * Add support for reading PCR (#146) * Add support for permission groups to AWS features (#147) * Add support for reading deployment IP addresses (#148) * Add missing private container registry comments (#142) * Cleanup now removes all AWS features (#149) * Fix shared exocompute (#150) * Fix AWS account list functionality (#151) * Add support for BYOK clusters (#152) * Fix feature permission group updates (#154) * Fix BYOK connect cluster query (#155) * Update AWS PCR documentation (#156) * Add support for BYOK8s cluster disconnect (#157) * Update dependencies and bump compiler version (#159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.