Fix an issue with AWS exocompute customer supplied security groups #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the exocompute configuration, the supplied security groups was checked to exist, but the boolean condition was inverted.
leitzler
approved these changes
May 3, 2024
johan3141592
added a commit
that referenced
this pull request
Aug 5, 2024
* Add support specifying Azure resource groups for RSC features (#160) * Add retry to allVpcsByRegion request (#162) * Move the retry handling into the Request function (#165) * Expose account name and FQDN (#166) * Add support for Azure shared exocompute (#167) * Fix an issue with AWS exocompute customer supplied security groups (#168) * Add support for Azure archival locations (#169) * Fix Azure permission upgrade issue (#170) * Increase the korg job wait attempts to 50 (#171) * Skip disabling AWS Exocompute for non-CFT workflow (#172) * Fix CreateStorageSetting's NativeID field (#173) * Use RSC_MANAGED_CLUSTER permission group (#174) * Extend AddClusterToExocomputeConfig to return setup YAML (#175) * Disable S3 protection before removing the feature (#176) * Fix failing Azure integration tests (#177) * Work around an AWS multiple features removal issue (#178) * Add functions to look up cloud accounts by native ID and name (#180) * Add support for updating AWS archival location bucket tags (#179)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the exocompute configuration, the supplied security groups was checked to exist, but the boolean condition was inverted.