Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error on FreeBSD 14 #1014

Merged

Conversation

janbiedermann
Copy link
Contributor

compiling atomic_reference.c
atomic_reference.c:108:53: error: incompatible integer to pointer conversion passing 'VALUE' (aka 'unsigned long') to parameter of type 'void *' [-Wint-conversion]
  if (__sync_bool_compare_and_swap(&DATA_PTR(self), expect_value, new_value)) {
                                                    ^~~~~~~~~~~~
atomic_reference.c:108:67: error: incompatible integer to pointer conversion passing 'VALUE' (aka 'unsigned long') to parameter of type 'void *' [-Wint-conversion]
  if (__sync_bool_compare_and_swap(&DATA_PTR(self), expect_value, new_value)) {
                                                                  ^~~~~~~~~
2 errors generated.
*** Error code 1

@eregon eregon merged commit 068212f into ruby-concurrency:master Nov 21, 2023
12 checks passed
@sunpoet
Copy link

sunpoet commented Feb 17, 2024

compiling atomic_reference.c
atomic_reference.c:108:53: error: incompatible integer to pointer conversion passing 'VALUE' (aka 'unsigned long') to parameter of type 'void *' [-Wint-conversion]
  if (__sync_bool_compare_and_swap(&DATA_PTR(self), expect_value, new_value)) {
                                                    ^~~~~~~~~~~~
atomic_reference.c:108:67: error: incompatible integer to pointer conversion passing 'VALUE' (aka 'unsigned long') to parameter of type 'void *' [-Wint-conversion]
  if (__sync_bool_compare_and_swap(&DATA_PTR(self), expect_value, new_value)) {
                                                                  ^~~~~~~~~
2 errors generated.
*** Error code 1

Why did you see this after freebsd/freebsd-ports@ec4c6e9 ?

@janbiedermann
Copy link
Contributor Author

Why did you see this after freebsd/freebsd-ports@ec4c6e9 ?

I do not use the port, i never looked at it, so I would not know, also i am not sure what you want to know by asking me why?

@janbiedermann
Copy link
Contributor Author

Why did you see this after freebsd/freebsd-ports@ec4c6e9 ?

I see, you appear to be the author of the port or port fix. If my fix interferes with your port, i am sorry, but as i said, the way i use ruby with freebsd is completely without ports, because i need to switch ruby version for development and testing and require specific versions, etc.. Therefore whatever happens in the ports tree with ruby does not affect me. Anyway, i think in general its a advisable way to fix things upstream, so it works for everybody, not only ports users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants