Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in edge promises #661

Merged
merged 1 commit into from
Jul 23, 2017
Merged

Fix error handling in edge promises #661

merged 1 commit into from
Jul 23, 2017

Conversation

hobodave
Copy link
Contributor

@hobodave hobodave commented Jun 6, 2017

  • Now properly handles errors raised within deeply nested futures.
  • value! now properly works with rejected_future

Fixes #659

Fix error handling in edge promises
cced0a7 
* Now properly handles errors raised within deeply nested futures.
* `value!` now properly works with `rejected_future`

Fixes ruby-concurrency#659
@hobodave
Copy link
Contributor Author

hobodave commented Jun 8, 2017

@pitr-ch ping

pitr-ch
pitr-ch approved these changes Jul 23, 2017
View reviewed changes
Copy link
Member

@pitr-ch pitr-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix and sorry I did not get to it sooner.

@pitr-ch pitr-ch merged commit 264e2c1 into ruby-concurrency:master Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitr-ch pitr-ch pitr-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobodave @pitr-ch