Allow TimerSet to safely handle an executor raising RejectedExecutionError
#999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889
The TimerSet creates a reactor-like loop to pop scheduled tasks off a queue at their appropriate time. If the task's executor has a fallback policy of
:abort
, the executor can raise aConcurrent::RejectedExecutionError
within the loop and break it. This PR introduces a rescue to handle and discard that exception.I think a
RejectedExecutionError
is the only exception that the executor is expected to raise, but this could be turned into rescuing any StandardError (either with a rescue or wrapping further in aSafeTaskExecutor
(that introduces even more blocks and locks).Also, this only rescues the exception within the loop that handles future-scheduled tasks. There is a magic
0.01
-seconds in the TimerSet which will cause the task to be executed immediately rather than deferred which I did not wrap:concurrent-ruby/lib/concurrent-ruby/concurrent/executor/timer_set.rb
Lines 97 to 100 in ee0ea41