-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the Globals middleware #1005
Conversation
The second part needs a test, please. And update CHANGELOG. |
9dfc5e5
to
da2e944
Compare
updated to include tests and an updated changelog |
You've been Rubocop-ed :) |
da2e944
to
bf20a81
Compare
fixed. |
@@ -19,6 +19,7 @@ | |||
* [#936](https://github.com/intridea/grape/pull/936): Fixed default params processing for optional groups - [@dm1try](https://github.com/dm1try). | |||
* [#942](https://github.com/intridea/grape/pull/942): Fixed forced presence for optional params when based on a reused entity that was also required in another context - [@croeck](https://github.com/croeck). | |||
* [#1001](https://github.com/intridea/grape/pull/1001): Fixed calling endpoint with specified format with format in its path - [@hodak](https://github.com/hodak). | |||
* [#1005](https://github.com/intridea/grape/pull/1005): Fixed the globls middleware - [@urkle](https://github.com/urkle). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: globAls, maybe say "Fixed Grape::Middleware::Globals
"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
- add to the autoload configuration - fix issues with it accessing an undefined var/method
bf20a81
to
f9e52fc
Compare
Thanks, merged. |
This is a fix for #1003