Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the Globals middleware #1005

Merged
merged 1 commit into from
Apr 30, 2015
Merged

Conversation

urkle
Copy link
Contributor

@urkle urkle commented Apr 29, 2015

  • add to the autoload configuration
  • fix issues with it accessing an undefined var/method

This is a fix for #1003

@dblock
Copy link
Member

dblock commented Apr 29, 2015

The second part needs a test, please. And update CHANGELOG.

@urkle urkle force-pushed the fix-globals-middleware branch from 9dfc5e5 to da2e944 Compare April 29, 2015 14:23
@urkle
Copy link
Contributor Author

urkle commented Apr 29, 2015

updated to include tests and an updated changelog

@dblock
Copy link
Member

dblock commented Apr 29, 2015

You've been Rubocop-ed :) rubocop -a fixes most problems, amend/push please.

@urkle urkle force-pushed the fix-globals-middleware branch from da2e944 to bf20a81 Compare April 29, 2015 19:53
@urkle
Copy link
Contributor Author

urkle commented Apr 29, 2015

fixed.

@@ -19,6 +19,7 @@
* [#936](https://github.com/intridea/grape/pull/936): Fixed default params processing for optional groups - [@dm1try](https://github.com/dm1try).
* [#942](https://github.com/intridea/grape/pull/942): Fixed forced presence for optional params when based on a reused entity that was also required in another context - [@croeck](https://github.com/croeck).
* [#1001](https://github.com/intridea/grape/pull/1001): Fixed calling endpoint with specified format with format in its path - [@hodak](https://github.com/hodak).
* [#1005](https://github.com/intridea/grape/pull/1005): Fixed the globls middleware - [@urkle](https://github.com/urkle).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: globAls, maybe say "Fixed Grape::Middleware::Globals"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

- add to the autoload configuration
- fix issues with it accessing an undefined var/method
@urkle urkle force-pushed the fix-globals-middleware branch from bf20a81 to f9e52fc Compare April 29, 2015 20:34
dblock added a commit that referenced this pull request Apr 30, 2015
@dblock dblock merged commit dd0cae2 into ruby-grape:master Apr 30, 2015
@dblock
Copy link
Member

dblock commented Apr 30, 2015

Thanks, merged.

@urkle urkle deleted the fix-globals-middleware branch September 19, 2015 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants