Detect content type correctly if raised any low level errors

[hamedrnik]

If Rack level errors raise, content type of the request couldn't be detected correctly. Basically there are two types of errors might happen in Rack level, Rack::Utils::ParameterTypeError and Rack::Utils::InvalidParameterError.
Passing query parameters like x[y]=1&x[y]z=2 and foo%81E=1 will raise the Rack level errors and the content type couldn't be detected correctly.

PS: appraisal rake spec raises two errors which are related to autoloading in Rails. How can I solve this problem?

[dblock]

Why would we want to swallow this error here? I would think it should just go upstream and be handled by whatever rescue_from in the Grape API declaration.

[hamedrnik]

@dblock That's exactly what I'm doing. I have resuce_from in my app and resuce these rack level errors but the problem is content type couldn't be detected correctly and I should hard code the content type. e.g.

rescue_from Rack::Utils::ParameterTypeError do |e|
  error_model = Models::Error.new(e)

  error!({
    errors: Serializers::Errors.new.serialize([error_model])
  }, error_model.status_code, 'Content-Type' => 'application/json')
end

This patch is only for detecting the response content type correctly. That's not for handling Rack level errors.

Thanks

[dblock]

I get it, I'm cool with merging it on green.

[dblock]

Missing a period at the end.

I think the description is a bit misleading. Your problem is content type, but what is being fixed is about handling an invalid query string when trying to detect the response format, no?

[hamedrnik]

Yes you're right. I updated the description. Thanks

[hamedrnik]

I get it, I'm cool with merging it on green.

As I said earlier in the patch description appraisal rake spec raises uninitialized constant Rack::Utils::ParameterTypeError error. Do you know how I can solve it? I guess I should add an autoload to lib/grape.rb, shouldn't I?

[dblock]

If you're missing a require then obviously yes. Why doesn't it fail on Ruby 2.3.0?