Fix absence of original_exception and/or backtrace even if passed in error!

[numbata]

Fix the case where backtrace and/or original_exception arguments are passed, but then do not become part of the returned message, even if backtrace: true and/or original_exception: true are set at the rescue_from level.

Fixes #2470

Thanks to @ericproulx for pointing out the problem and provided specs.

[ericproulx]

@dblock anything to add ?

[ericproulx]

The only think that bugs me is the error? function. It looks for an hash with specific keys. Somehow, I think we could throw a more concrete object like a class or a struct instead of an hash. Something Like

Error = Struct.new(:message, :status, :headers, :backtrace, :original_exception)

....
throw Errow.new(message, status, headers, backtrace, original_exception)
...

case response
when Error
when Rack::Response
else
end

But this is another discussion 😛

[numbata]

The only think that bugs me is the error? function.

Totally agree. And we can do something around that (in separate PR ofc), but I have fear that will be breaking changes.

[ericproulx]

The only think that bugs me is the error? function.

Totally agree. And we can do something around that (in separate PR ofc), but I have fear that will be breaking changes.

If its only for internal/private usage, we should be fine with the breaking changes :)

[ericproulx]

Thanks @numbata

[numbata]

If its only for internal/private usage, we should be fine with the breaking changes :)

I just allow that some of the grape users have something like:

rescue_from do |e|
  throw :error, message: "foo", status: 200, headers: {}
end

or directly:

get "/foo" do
  throw :error, message: "oopsie", status: 200, headers: {}
end

[dblock]

Don't remove this line next time ;)

[numbata]

🙈

[numbata]

Let's say that I believe that there will only be new features in the next release and no fixes 🤞.

[ericproulx]

Sorry about that @dblock

[numbata]

It looks like a new "check" can be added to the "danger-changelog" gem.

[dblock]

For sure, we take PRs :)

[dblock]

@dblock anything to add ?

Ya'll are fast than me! Thanks.