Revisit versioner middlewares #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `const_get` to find versioner Grape::Middleware::Versioner::* uses `default_options` like other middlewares Add versioner_helpers for Grape::Middleware::Versioner::* Replace `merge` by `deep_merge` in Grape::Middleware::Base initialize Add specs
dblock
reviewed
Jul 26, 2024
Use `camelize` instead of `classify`
dblock
reviewed
Jul 27, 2024
There's already the accept_version_header_spec that covers all cases. Coverage is 100% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor of all Grape::Middleware::Versioner
First, they all use the
default_optionslike the other middlewares. Since defaultversion_optionsis including another Hash, I had to replacemergebydeep_mergein Grape::Middleware::Base.Second, the
usingstrategy is now dynamically solved like validators. It's all based on the name of the class.Third, I've added a
versioner_helpersthat all Grape::Middleware::Versioner include. At least, all theoptions[...]are exposed through an helper function which reduces the[]calls.