error! in rescue from blocks

[sunnyrjuneja]

I was having a similar problem with ValidationErrors#to_json as I was with ValidationErrors#as_json (see: #889). If there's preferred fix, please let me know.

[sunnyrjuneja]

Also, it's possible to remove error_response and sub in error! but it was getting pretty confusing. There seems to be a bit of coupling with the method signature of error_response and the rest of the code. I can send another PR for that or append it here.

[dblock]

Generally I would omit the parenthesis here.

[dblock]

This needs a CHANGELOG entry and please squash your commits.

[sunnyrjuneja]

@dblock Thanks for your fast response. I've applied your recommendations. Let me know if you have anymore feedback.

[dblock]

I like this, merging.

[u2]

0.28.0 (10/12/2014)

New features

New cop ExtraSpacing points out unnecessary spacing in files.

This feature has been released in 0.28.0, I think it's a bug of rubocop, anyway I create a commit for updating robocop version.

[binary1101]

still doesn't work in 0.14.0

class Twitter::API < Grape::API
  format :json
  helpers do
    def server_error!
      error!({ error: 'Server error.' }, 500, { 'Content-Type' => 'text/error' })
    end
  end

  rescue_from :all do |e|
    server_error!
  end
end

[dblock]

@binary1101 how does it not work exactly? Open a new issue please