Update post install message for rails 5.2.2 default behavior #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems sensible to me. Thank you for updating this message. |
indigolain
deleted the
update_post_install_message_for_rails_default_behavior_in_5_2_2
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that from rails 5.2.2, there was a change in the default behavior when
config.i18n.fallbackswas set to true.rails/rails#33574
rails/rails@83d6aaa
The change in rails provides compatibility, but I am guessing that since the pull request which added the post-install message ( #442) had a link to this change, so I am wondering that there was something in mind not specifying 5.2.2 as the version.