Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating DEFAULT_APPROXIMATIONS with capitalised German Eszett character for consistency #627

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

lucapericlp
Copy link
Contributor

The uppercase equivalent of the German Eszett was released in a much later version of Unicode and isn't included as part of the first 190 diacritics of unicode between 0xC0 & 0x17E so I thought I'd raise this PR in case consistency is desired.

@lucapericlp
Copy link
Contributor Author

Apologies for the direct ping @radar (lmk whom else I might be able to ping in case) but I saw you recently merged in another PR - is this worth including or should we close?

@radar radar merged commit a544c8d into ruby-i18n:master Nov 5, 2022
@radar
Copy link
Collaborator

radar commented Nov 5, 2022

Sorry @lucapericlp, I must've missed this one back in May somehow. I try to review things within at least two weeks and give feedback then.

The change looks good now. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants