-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to specify integer and bool proto fields as string. #253
Merged
abrandoned
merged 1 commit into
ruby-protobuf:master
from
hrsht:support_string_for_integers_and_bools
Apr 14, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
require 'spec_helper' | ||
|
||
RSpec.describe Protobuf::Field::Int32Field do | ||
|
||
class SomeBoolMessage < ::Protobuf::Message | ||
optional :bool, :some_bool, 1 | ||
end | ||
|
||
let(:instance) { SomeBoolMessage.new } | ||
|
||
describe '#define_setter' do | ||
subject { instance.some_bool = value; instance.some_bool } | ||
|
||
[true, false].each do |val| | ||
context "when set with #{val}" do | ||
let(:value) { val } | ||
|
||
it 'is readable as a bool' do | ||
expect(subject).to eq(val) | ||
end | ||
end | ||
end | ||
|
||
[['true', true], ['false', false]].each do |val, expected| | ||
context "when set with a string of #{val}" do | ||
let(:value) { val } | ||
|
||
it 'is readable as a bool' do | ||
expect(subject).to eq(expected) | ||
end | ||
end | ||
end | ||
|
||
context 'when set with a non-bool string' do | ||
let(:value) { "aaaa" } | ||
|
||
it 'throws an error' do | ||
expect { subject }.to raise_error(TypeError) | ||
end | ||
end | ||
|
||
context 'when set with something that is not a bool' do | ||
let(:value) { [1, 2, 3] } | ||
|
||
it 'throws an error' do | ||
expect { subject }.to raise_error(TypeError) | ||
end | ||
end | ||
end | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? (the .to_i and is_a?(Numeric) check)
we have been looking at standardizing serialization with this branch
https://github.com/localshred/protobuf/compare/bdewitt/fix_coercion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required to convert a float to an integer, unless that should be disallowed.
Also,
Integer('0x10')
produces 16. IMO, it should return an error and hence requiresInteger(val, 10)
which throws an error ifval
is of type Numeric.