Skip to content

Commit

Permalink
Upgrade test matrix (#739)
Browse files Browse the repository at this point in the history
* First pass at updated spec matrix

* Next try

* Try pry-byebug again

* Looks like a Pry problem

* Fix this in the Ruby gemfile

* Looks like these have to go together

* Now we're trying to have the 3.2 version use a different gemfile

* I wonder if it'll do the right thing if we don't try to pin byebug
  • Loading branch information
noelrappin authored Aug 16, 2023
1 parent f24db54 commit 3099c57
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 4 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: All Specs
strategy:
matrix:
ruby: ['2.4', '2.5', '2.6', '2.7', '3.0']
ruby: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
gemfile: ['Gemfile', 'gemfiles/aws_sdk_core_2.gemfile']
runs-on: ubuntu-20.04
services:
Expand All @@ -34,7 +34,7 @@ jobs:
name: Rails Specs
strategy:
matrix:
rails: ['4.2', '5.2', '6.0', '6.1']
rails: ['4.2', '5.2', '6.0', '6.1', '7.0']
include:
- rails: '4.2'
ruby: '2.2'
Expand All @@ -48,6 +48,9 @@ jobs:
- rails: '6.1'
ruby: '3.0'
gemfile: gemfiles/rails_6_1.gemfile
- rails: '7.0'
ruby: '3.1'
gemfile: gemfiles/rails_7_0.gemfile
runs-on: ubuntu-20.04
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
Expand Down
6 changes: 6 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@ appraise 'rails_6_1' do
gem 'activejob', '~> 6.1'
end
end

appraise 'rails_7_0' do
group :test do
gem 'activejob', '~> 7.0'
end
end
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ end

group :development do
gem 'appraisal', git: 'https://github.com/thoughtbot/appraisal.git'
gem 'pry-byebug', '3.9.0'
gem 'pry-byebug'
gem 'rubocop', '<= 1.12'
end
2 changes: 1 addition & 1 deletion gemfiles/aws_sdk_core_2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ end

group :development do
gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
gem "pry-byebug", "3.9.0"
gem "pry-byebug"
gem "rubocop"
end

Expand Down
22 changes: 22 additions & 0 deletions gemfiles/rails_7_0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# This file was generated by Appraisal

source "https://rubygems.org"

group :test do
gem "activejob", "~> 7.0"
gem "aws-sdk-core", "~> 3"
gem "aws-sdk-sqs"
gem "codeclimate-test-reporter", require: nil
gem "httparty"
gem "multi_xml"
gem "simplecov"
end

group :development do
gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git"
gem "rubocop"
gem "pry", ">= 0.14.2"
gem "pry-byebug", ">= 3.10.1"
end

gemspec path: "../"

0 comments on commit 3099c57

Please sign in to comment.