Pass the queue into the message object on initialize. #127
Conversation
| else | ||
| # TODO: Remove next major release | ||
| Shoryuken.loggger.warn do | ||
| "[DEPRECATION] Passing a queue url into Shoryuken::Message is deprecated, please pass the queue itself" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Senjai
force-pushed
the
queue_args
branch
2 times, most recently
from
649d83f to
22f11d2
Compare
| attr_accessor :client, :queue_url, :queue_name, :data | ||
|
|
||
| def initialize(client, queue, data) | ||
| client = client |
There was a problem hiding this comment.
Useless assignment to variable - client.
Instead of just passing in the queue url, pass in the queue instead. We can take what information we need, or delegate certain behavior if we choose to store the queue which would require no further interface changes.
|
Hi @Senjai This is basically adding the |
|
We use several queues and a broker to manage them. We use a general failure The assignment makes it easy, i can remove it, if we keep the queue as an |
Pass the queue into the message object on initialize.
|
@Senjai gotcha. Makes sense. Thanks, added to master 🍻 |
Instead of just passing in the queue url, pass in the queue instead. We
can take what information we need, or delegate certain behavior if we
choose to store the queue which would require no further interface
changes.