Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto extend error when using an ActiveJob wrapper #213

Closed
wants to merge 3 commits into from
Closed

Fix auto extend error when using an ActiveJob wrapper #213

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c46aae
Fix auto extend error when using an ActiveJob wrapper
May 23, 2016
3a51d49
Fix `Line is too long. [138/120]`
May 23, 2016
ca192b4
Fix for `Align the operands of a condition in an "if statement" spann…
May 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/shoryuken/util.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ def worker_name(worker_class, sqs_msg, body = nil)
&& !sqs_msg.is_a?(Array) \
&& sqs_msg.message_attributes \
&& sqs_msg.message_attributes['shoryuken_class'] \
&& sqs_msg.message_attributes['shoryuken_class'][:string_value] == ActiveJob::QueueAdapters::ShoryukenAdapter::JobWrapper.to_s
&& sqs_msg.message_attributes['shoryuken_class'][:string_value] == \
ActiveJob::QueueAdapters::ShoryukenAdapter::JobWrapper.to_s \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the operands of a condition in an if statement spanning multiple lines.

&& body
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @takeyuweb

So can body be empty when `ActiveJob?


"ActiveJob/#{body['job_class']}"
else
Expand Down