Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shoryuken_options doesn't change arguments #431

Merged
merged 1 commit into from
Aug 31, 2017
Merged

shoryuken_options doesn't change arguments #431

merged 1 commit into from
Aug 31, 2017

Conversation

ota42y
Copy link
Contributor

@ota42y ota42y commented Aug 31, 2017 •
edited
Loading

The shoryuken_option method break arguments.
So we can't reuse option value.. :(

This change stringify_keys method create new hash and return it.

@ota42y ota42y force-pushed the bugfix/safe_shoryuken_option branch from 65c4a5d to 131146a Compare August 31, 2017 09:12
@ota42y ota42y force-pushed the bugfix/safe_shoryuken_option branch from 131146a to e0bdc1c Compare August 31, 2017 11:59
@ota42y
Copy link
Contributor Author

ota42y commented Aug 31, 2017

The test failed.
But it's another cause that has no relation
See #432

@phstc phstc changed the title 🐛 shoryuken_options doesn't change arguments shoryuken_options doesn't change arguments Aug 31, 2017
@phstc phstc merged commit e0bdc1c into ruby-shoryuken:master Aug 31, 2017
@phstc
Copy link
Collaborator

phstc commented Aug 31, 2017 •
edited
Loading

Thanks @ota42y. Added to master 🍻

@ota42y ota42y deleted the bugfix/safe_shoryuken_option branch September 1, 2017 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota42y @phstc