Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework inlay hints to match the spec #103

Closed
kddnewton opened this issue Jun 23, 2022 · 0 comments · Fixed by #106
Closed

Rework inlay hints to match the spec #103

kddnewton opened this issue Jun 23, 2022 · 0 comments · Fixed by #106

Comments

@kddnewton
Copy link
Member

At the time that I wrote the inlay hints stuff for the language server, inlay hints were not actually a part of the LSP. Since then, they have been added. If we conform to the spec, we can greatly simplify vscode-syntax-tree because it won't have to handle deduping itself and can just let the client handle it. Additionally, it will work for clients that aren't vscode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant