Performance #170
Merged
Performance #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
reviewed
Oct 17, 2022
| # In case we're running on an older Ruby version, we polyfill it here. | ||
| unless :+.respond_to?(:name) | ||
| class Symbol # rubocop:disable Style/Documentation | ||
| def name |
There was a problem hiding this comment.
Hum, that polyfill might trick other gems or code into thinking they are on 3.0. Have you considered using a refinement here? I generally avoid them like the plague, but for unobstrusive polyfill I found them relatively useful.
There was a problem hiding this comment.
Ahh yeah I can make it a refinement.
There was a problem hiding this comment.
Turns out I stopped using it in as many places as I thought, this is much better now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.