Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build failed with ruby 2.6.7 #83

Closed
akiotajima opened this issue Dec 13, 2022 · 1 comment · Fixed by #84
Closed

build failed with ruby 2.6.7 #83

akiotajima opened this issue Dec 13, 2022 · 1 comment · Fixed by #84

Comments

@akiotajima
Copy link

According to https://rubygems.org/gems/date, 'date' supported ruby version was >=2.4.
However date_core.c refers RB_WARN_CATEGORY_DEPRECATED introduced by Ruby 3.
I wonder if you could check RB_WARN_* in the build process or #Ifndef or anything.
Thanks.
@hsbt hsbt changed the title build failed with ruy 2.6.7 build failed with ruby 2.6.7 Dec 13, 2022
hsbt added a commit that referenced this issue Dec 14, 2022
@hsbt
Fixed wrong minimum version of Ruby
9731a3e 
  Fixed #83
@hsbt hsbt mentioned this issue Dec 14, 2022
Merged
@hsbt
Copy link
Member

hsbt commented Dec 14, 2022

Thanks. It's wrong required version of gemspec. We only test with Ruby 2.7+. I update gemspec and test versions at #84.

I'm not sure there is strong reason to remove Ruby 2.6 now. I add it to them.

@hsbt hsbt closed this as completed in #84 Dec 14, 2022
matzbot pushed a commit to ruby/ruby that referenced this issue Dec 14, 2022
@hsbt @matzbot
[ruby/date] Fixed wrong minimum version of Ruby
bec7deb 
  Fixed ruby/date#83

ruby/date@9731a3e732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed wrong minimum version of Ruby ruby/date
2 participants
@hsbt @akiotajima