Improve assert_repl_result for CDP #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation doesn't work when the result is a boolean type because the helper calls `#inspect` on the values of `JAVASCRIPT_TYPE_TO_CLASS_MAPS`, which is an array for boolean types. Example failure: ``` <["[TrueClass, FalseClass]"]> was expected to include <"FalseClass">. ``` Since `JAVASCRIPT_TYPE_TO_CLASS_MAPS` is never used in other places, we can just store the String representation of the class name in the hash and thus avoid calling `#inspect` on the values.
|
By the way, I think that JAVASCRIPT_TYPE_TO_CLASS_MAPS is not the best name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't work when the result is a boolean type because the helper calls
#inspecton the values ofJAVASCRIPT_TYPE_TO_CLASS_MAPS, which is an array for boolean types.Example failure:
Since
JAVASCRIPT_TYPE_TO_CLASS_MAPSis never used in other places, we can just store the String representation of the class name in the hash and avoid calling#inspecton the values.