Check if rb_syserr_fail_str is available
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truffle ruby seems to lack it.
eregon
reviewed
Dec 2, 2024
| @@ -5,6 +5,10 @@ | |||
| # See https://bugs.ruby-lang.org/issues/20345 | |||
| MakeMakefile::RbConfig ||= ::RbConfig | |||
|
|
|||
| have_func("rb_syserr_fail_str(0, Qnil)") or | |||
There was a problem hiding this comment.
FWIW I think have_func("rb_syserr_fail_str") should be enough, both eventually error with on TruffleRuby 24.1.1:
conftest.c:15: undefined reference to `rb_syserr_fail_str'
for me on Linux, and both are yes on CRuby 3.2.2.
eregon
reviewed
Dec 2, 2024
| @@ -125,6 +125,10 @@ io_get_write_io_fallback(VALUE io) | |||
| #define rb_io_get_write_io io_get_write_io_fallback | |||
| #endif | |||
|
|
|||
| #ifndef DHAVE_RB_SYSERR_FAIL_STR | |||
There was a problem hiding this comment.
Is this correct?
Running on CRuby 3.2.2, have_func("rb_syserr_fail_str(0, Qnil)") defines HAVE_RB_SYSERR_FAIL_STR, not DHAVE_RB_SYSERR_FAIL_STR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truffle ruby seems to lack it.