Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InvalidAddressError message #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ishikawa999
Copy link

@ishikawa999 ishikawa999 commented Apr 27, 2024

This pull request will fix issue #60.
Fix to use the addr variable that exists instead of the non-existent @addr.

@ishikawa999 ishikawa999 requested a review from knu as a code owner April 27, 2024 07:29
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@corrupt952
Copy link

@ishikawa999 @knu

What is the status of this PR?
It looks like 65a4c41 was merged last week, so if I re-checkout from master or merging master, the build that is failing on this PR appears to be ready to go through.

@knu
Copy link
Member

knu commented Aug 14, 2024

The current status is CI failure left. As far as I recall, I approved this PR waiting for the tests to finish, and then some of them failed.

The failed actions cannot be rerun by now, so you'll have to push again to trigger a new run.

I guess Ruby 2.4 & 2.5 on macOS may be removed if they still fail again because those versions are too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants