Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug infinite loop when pasting multilines fo code in Ruby 2.6 #309

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

osyo-manga
Copy link
Contributor

Description

Fix bug infinite loop when pasting multilines fo code in Ruby 2.6.
This is not reproduced in Ruby 2.7.
Changes added in https://github.com/ruby/irb/pull/242/files#diff-612b926e42ed78aed1a889ac1944f7d22229b3a489cc08f837a7f75eca3d3399R155 are also reflected in Ruby 2.6.

This bug was found by @ima1zumi, Thanks!! :)

Steps to reproduce

  1. Run irb
  2. Pasting multilines of code
def hoge
end
  1. Infinite loop

simplescreenrecorder-2021-11-23_22 56 41

Result of irb_info

$ RBENV_VERSION=2.6.8 bundle exec irb
irb(main):001:0> irb_info
=>
Ruby version: 2.6.8
IRB version: irb 1.3.8.pre.11 (2021-10-09)
InputMethod: ReidlineInputMethod with Reline 0.2.8.pre.11
RUBY_PLATFORM: x86_64-linux
LANG env: ja_JP.UTF-8

irb(main):002:0>

Terminal Emulator

  • GNOME Terminal 3.36.2

Setting Files

None setting files.

Fix bug infinite loop when pasting multilines fo code in Ruby 2.6.
This is not reproduced in Ruby 2.7.
Changes added in https://github.com/ruby/irb/pull/242/files#diff-612b926e42ed78aed1a889ac1944f7d22229b3a489cc08f837a7f75eca3d3399R155 are also reflected in Ruby 2.6.
@osyo-manga osyo-manga marked this pull request as ready for review November 23, 2021 14:19
@aycabta
Copy link
Member

aycabta commented Dec 2, 2021

OK, great!

@aycabta aycabta merged commit 7820fff into ruby:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants