Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regarding NO_COLOR value #387

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Update regarding NO_COLOR value #387

merged 2 commits into from
Oct 28, 2022

Conversation

nobu
Copy link
Member

@nobu nobu commented Aug 5, 2022

https://no-color.org has been updated (jcs/no_color#83):

Command-line software which adds ANSI color to its output by default
should check for a NO_COLOR environment variable that, when present
and not an empty string (regardless of its value), prevents the
addition of ANSI color.

https://no-color.org proposes:

> Command-line software which adds ANSI color to its output by default
should check for a `NO_COLOR` environment variable that, when present
and **not an empty string** (regardless of its value), prevents the
addition of ANSI color.
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, but I think it's already good to merge 👍

lib/irb/init.rb Outdated Show resolved Hide resolved
Co-authored-by: Stan Lo <stan001212@gmail.com>
@nobu nobu changed the title Fix empty NO_COLOR Update regarding NO_COLOR value Oct 28, 2022
@nobu nobu merged commit 46e0f7e into ruby:master Oct 28, 2022
@nobu nobu deleted the empty-NO_COLOR branch October 28, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants