Add test for the help command #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
commented
Oct 24, 2022
|
|
||
| ::Kernel.define_method(:require) do |name| | ||
| raise LoadError, "cannot load such file -- rdoc (test)" if name == "rdoc" | ||
| original_require(name) |
There was a problem hiding this comment.
Here's a typo, but in these tests it's never reached 🙈
test/lib/helper.rb
Outdated
| ::Kernel.send(:alias_method, :old_require, :require) | ||
|
|
||
| ::Kernel.define_method(:require) do |name| | ||
| raise LoadError, "cannot load such file -- rdoc (test)" if name.match?("rdoc") || name.match?(/^rdoc\/.*/) |
There was a problem hiding this comment.
I expanded it to match rdoc or rdoc/*.
|
@junaruga I think different |
OK. Thanks for the work! |
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
st0012
force-pushed
the
add-test-for-help
branch
from
38c4602 to
a87ea90
Compare
st0012
force-pushed
the
add-test-for-help
branch
from
a87ea90 to
cc6e6d2
Compare
st0012
commented
Oct 25, 2022
| "help 'String#gsub'\n", | ||
| "\n", | ||
| ]) | ||
| IRB.conf[:PROMPT_MODE] = :SIMPLE |
There was a problem hiding this comment.
@peterzhu2118 This one is needed to reduce noise from the output.
st0012
force-pushed
the
add-test-for-help
branch
from
ec9440e to
df4536e
Compare
st0012
commented
Oct 26, 2022
Ruby CI runs irb and other Ruby core/stdlib tests in the same process. So adding irb-specific helper to Test::Unit::TestCase could potentially pollute other components' tests and should be avoided.
st0012
force-pushed
the
add-test-for-help
branch
from
df4536e to
e08c981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for 2 of 3 possible
helpcommand outcomes:rdoc: it returns the command constant directlyhelp String#gsub: it renders the argument's document viardocBecause the
helpcommand redefines itself based on if rdoc is required succesfully, there's no easy way to recover it to the pre-test state. I think the best way is to reload the command file, but any alternative is welcome.