Remove unnecesary and harmful pend for TruffleRuby in TestRaiseNoBacktraceException #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Oct 27, 2022
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
|
The test fails because and such a locale is most likely not installed in GitHub Actions, and so I guess nl_langinfo(CODESET) returns ASCII or C or similar.
So maybe the test does not run as expected (on CRuby on GitHub Actions)? |
eregon
changed the title
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Oct 28, 2022
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Nov 1, 2022
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Nov 2, 2022
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Nov 4, 2022
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Nov 7, 2022
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Feb 24, 2023
* And add missing require.
nirvdrum
pushed a commit
to Shopify/truffleruby
that referenced
this pull request
Mar 2, 2023
* And add missing require.
john-heinnickel
pushed a commit
to thermofisher-jch/truffleruby
that referenced
this pull request
Aug 16, 2023
…raceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
* See ruby/irb#423
john-heinnickel
pushed a commit
to thermofisher-jch/truffleruby
that referenced
this pull request
Aug 16, 2023
* And add missing require.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$HOMEto be unset, which breaksFile.expand_path('~').The issue was introduced in 4452adb, cc @aycabta