Don't lazily retrieve gem specs for completion #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few downsides of the current approach:
retrieve_files_to_require_from_load_path
)So by pre-computing and storing the gem paths in a constant, it guarantees that the computation only happens once and it doesn't get affected by test cases.
One argument could be made against the change is that, it'll store unnecessary data for users that disable autocompletion. But the counter-arguments are:
retrieve_files_to_require_from_load_path
in memory, which should have a similar size of GEM_SPECS. And we currently haven't received any report about problems caused by such memory consumption.Testing With Ruby
This script:
can reproduce the related test failures with Ruby:
But with this patch both of them should pass.