Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a huge difference between how tests are run in this repo and after being synced to Ruby CI. And that causes Ruby CI failure like this not being detected in the original PR #441. I think the rule of thumb is to have every test file self-contained, which is hard to verify with the current
rake test
.So in this PR I added
test_in_isolation
task, which runs each test file in isolation. With this task, we would be able to catch the above failure before the PR is merged.With this new task, I also caught another undiscovered error:
Which is now fixed in the last commit.