-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug
command
#446
Add debug
command
#446
Conversation
I've played with this implementation myself for a short while. This seems to be written pretty well. Great job 👍 Some minor feedback:
A question:
Normally, I would leave it to you to address them before merging it, but I have one idea I'd like to try on this implementation. So let me merge this first, file a pull request to address the first two points myself, and file another one to add one change if that works out. |
This is what I think Ruby development experience could be:
If you agree with the above premises, we can see that there's a scene transition in every usage, which is what I want to improve now:
(Sorry for sidetracking, now back to your question)
In this case, I think the question should be: why doesn't
This is a possibility. But before introducing any change to
|
If we get to support the full functionality of off topic: Speaking of making it a superset, I'm still kind of uncomfortable that C-d asks "Really quit? [Y/n]" and I'd like to add a configuration to make it work exactly like |
It now has
Personally I'd hope it to be |
I'm talking exactly about
So, when you put binding.irb and press C-d, do you want to quit the process instead of moving until it hits another binding.irb? binding.irb is like a breakpoint for me, so personally I don't understand why debug.gem just quits it instead of continuing it (unlike pry-byebug) or even asks it. |
In But with |
I also quit irb or pry immediately very often, but still less frequently than C-d to continue. Whether you put a breakpoint by a command or leaving a method call, it doesn't change the fact that you use contiune multiple times and quit only once in one program execution. So somehow a less frequently used command is made easier to input. The "Really quit?" prompt would be very annoying if you need to use it as frequently as contiune. I heard it's made that way because it's how gdb works. I'm the guy who use pry-byebug or irb more often, and debug is probably designed by people who use gdb more. |
Yeah that's true. But I don't use
I agree and feel that. And this is another behaviour that I wish it to match |
This implements and closes #425