Add edit command #453
Merged
Add edit command #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
suppot-edit-command
branch
4 times, most recently
from
02e3d69 to
ff6af14
Compare
k0kubun
reviewed
Nov 19, 2022
k0kubun
reviewed
Nov 19, 2022
st0012
force-pushed
the
suppot-edit-command
branch
from
ff6af14 to
b54e32f
Compare
st0012
force-pushed
the
suppot-edit-command
branch
from
b54e32f to
d7a58f4
Compare
k0kubun
reviewed
Nov 20, 2022
k0kubun
reviewed
Nov 20, 2022
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 20, 2022
* Add edit command * Make find_source a public singleton method * Add document for the edit command * Make find_end private * Remove duplicated private ruby/irb@4321674aa7 Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name
I originally wanted to name it
open. But sinceruby/debughas aneditcommand (the inspiration of this feature), I think it's better to match it.Usages
Editor is determined by
ENV["EDITOR"]edit- opens the current context's file in the editoredit foo.rb- opensfoo.rbin the editor if it existsIt also supports
show_sourcecompatible arguments, likeedit Fooedit Foo#baredit Foo.bazIn these cases, it'll use
show_sourceto resolve the argument's path and open them in the editor.Exceptions
irbcan't find a file with the argument, nor canShowSource#find_sourceresolve its source, it prints a message and stops.ENV["EDITOR"]is not defined, the command also prints a message and stops.