Activate yamatanooroti tests on CI #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
fix-yamatanooroti-tests
branch
3 times, most recently
from
4603be0 to
a30706c
Compare
st0012
force-pushed
the
fix-yamatanooroti-tests
branch
from
a30706c to
d720470
Compare
st0012
commented
Nov 26, 2022
| (rdbg:irb) delete 0 | ||
| deleted: #0 BP - Line #{@ruby_file}:5 (line) | ||
| deleted: #0 BP - Line |
There was a problem hiding this comment.
We need to loose this expectation because debug can show additional (pending) info based on Ruby versions (depending on iseq support).
Since we just want to test if debug receives the command and argument correctly, matching only this part of the message should be good enough.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 27, 2022
(ruby/irb#459) * Activate yamatanooroti tests on CI * Fix delete test ruby/irb@750cf4c480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env is also needed for running the tests, otherwise it won't load the
vtermgem and won't do anything.