Lazily load the multi-irb extension #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
k0kubun
reviewed
Dec 7, 2022
k0kubun
reviewed
Dec 7, 2022
k0kubun
reviewed
Dec 7, 2022
st0012
force-pushed
the
lazily-load-command-extensions
branch
2 times, most recently
from
d1af591 to
c79147c
Compare
st0012
changed the title
st0012
force-pushed
the
lazily-load-command-extensions
branch
2 times, most recently
from
1503c81 to
3fc0fe8
Compare
st0012
changed the title
We now have plan to implement a command that prints all commands' information, which will need to load all command files without actually running them. But because the `multi-irb` extension patches IRB's top-level methods, loading it would cause unintentional side-effects. So this commit moves related requires into command execution to avoid the problem.
st0012
force-pushed
the
lazily-load-command-extensions
branch
from
3fc0fe8 to
b001cb4
Compare
st0012
commented
Dec 7, 2022
| class MultiIRBCommand < Nop | ||
| def initialize(conf) | ||
| super | ||
| extend_irb_context |
There was a problem hiding this comment.
I think this is cleaner, wdyt?
k0kubun
reviewed
Dec 7, 2022
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 7, 2022
(ruby/irb#472) * Lazily load the multi-irb extension We now have plan to implement a command that prints all commands' information, which will need to load all command files without actually running them. But because the `multi-irb` extension patches IRB's top-level methods, loading it would cause unintentional side-effects. So this commit moves related requires into command execution to avoid the problem. * Make extend_irb_context private Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have plan to implement a command that prints all commands'
information, which will need to load all commands files without actually
running them.
But because the
multi-irbextension patches IRB's top-level methods,loading it would cause unintentional side-effects.
So this commit moves related requires into command execution to avoid the problem.