Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adjusting Index to Inline #394

Merged
merged 11 commits into from
May 17, 2024
Merged

Conversation

ydah
Copy link
Member

@ydah ydah commented Apr 9, 2024

No description provided.

@yui-knk
Copy link
Collaborator

yui-knk commented Apr 13, 2024

[note]
Some methods on RuleBuilder require parameterizing_rule_resolver for its argumen, e.g. #setup_rules, #has_inline_rules? and #resolve_inline_rules. It might be better to pass parameterizing_rule_resolver for RuleBuilder#initialize by adding helper function to Grammar which calls Grammar::RuleBuilder.new with @parameterizing_rule_resolver
It's not directly related to this PR, so I don't require to change it in this PR.

@yui-knk
Copy link
Collaborator

yui-knk commented Apr 13, 2024

@ydah The direction seems good. Could you check the logic of reference overwrite, #394 (comment) ?

@ydah ydah requested a review from yui-knk April 15, 2024 14:28
@ydah
Copy link
Member Author

ydah commented Apr 15, 2024

@yui-knk Thank you for your review! I updated this PR.

@ydah
Copy link
Member Author

ydah commented Apr 17, 2024

[note] Some methods on RuleBuilder require parameterizing_rule_resolver for its argumen, e.g. #setup_rules, #has_inline_rules? and #resolve_inline_rules. It might be better to pass parameterizing_rule_resolver for RuleBuilder#initialize by adding helper function to Grammar which calls Grammar::RuleBuilder.new with @parameterizing_rule_resolver It's not directly related to this PR, so I don't require to change it in this PR.

@yui-knk Add refactoring commit: 514e61c

@ydah
Copy link
Member Author

ydah commented May 17, 2024

@yui-knk I rebased and fix conflict.

@yui-knk yui-knk merged commit 48c4434 into ruby:master May 17, 2024
16 checks passed
@yui-knk
Copy link
Collaborator

yui-knk commented May 17, 2024

LGTM!

@ydah ydah deleted the inline-index branch May 17, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants